Implement CLI (closes #105) #118

inikulin · 2015-10-16T09:18:15Z

You can try it locally (please try it) by running in the shell:

mkdir test-cli && cd ./test-cli && \
git clone https://github.com/inikulin/testcafe-phoenix && \ 
cd ./testcafe-phoenix && git checkout cli && \
npm install && gulp build

Then to run CLI:

node bin/testcafe <args>

\cc @churkin @AlexanderMoskovkin @kirovboris
@VasilyStrelyaev check texts and test names, please

testcafe-build-bot · 2015-10-16T09:39:17Z

✅ Tests for the commit 24f1f3b have passed. See details.

kirovboris · 2015-10-16T10:03:19Z

src/cli/index.js

+}
+
+function waitBrowserConnectionReady (browserConnection) {
+    return new Promise((resolve)=> browserConnection.once('ready', resolve));


(resolve) -> resolve ?

kirovboris · 2015-10-16T11:29:10Z

I'm executing node bin/testcafe chrome,ie test.js, and getting

ERROR Cannot read property 'isTTY' of null

kirovboris · 2015-10-16T11:29:16Z

/r-

inikulin · 2015-10-16T11:38:44Z

In addition: Hammerhead errors are not handled correctly
Edit: issued in separate ticket - #120

VasilyStrelyaev · 2015-10-16T12:15:53Z

src/cli/argument-parser.js

+        this.opts = this.program.opts();
+
+        // NOTE: '-list-browsers' option just lists browsers and immediately exits app.
+        // Therefore, we don't need process other args


NOTE: the '-list-browsers' option only lists browsers and immediately exits the app.
Therefore, we don't need to process other arguments.

testcafe-build-bot · 2015-10-16T12:21:17Z

✅ Tests for the commit 37c3dd3 have passed. See details.

VasilyStrelyaev · 2015-10-16T13:19:45Z

\r-

VasilyStrelyaev · 2015-10-16T13:37:36Z

test/server/cli-argument-parser-test.js

+            .catch(done);
+    });
+
+    it("Should parse screenshots path and ensure it's existence", function (done) {


one more - it's -> its

or even better
Should parse the screenshot path and ensure it exists

VasilyStrelyaev · 2015-10-16T13:40:27Z

\r-

AlexanderMoskovkin · 2015-10-16T15:41:20Z

Is this an indents issue or it's ok?

inikulin · 2015-10-16T15:44:46Z

@AlexanderMoskovkin Definitely no. Need to figure out optimal string lengths with the final texts (which we now have thanks to @VasilyStrelyaev)

AlexanderMoskovkin · 2015-10-19T08:04:58Z

src/client/test-run/index.js.mustache

@@ -42,7 +42,7 @@
            CURRENT_TEST_STEP_NAME:   nextStep ? stepNames[nextStep - 1] : 'Test initialization',
            BROWSER_STATUS_URL:       '{{{browserStatusUrl}}}',
            TAKE_SCREENSHOT_ON_FAILS: {{{takeScreenshotOnFails}}},
-            FAIL_ON_JS_ERRORS:        {{{failOnJsErrors}}},
+            SKIP_JS_ERRORS:           {{{failOnJsErrors}}},


{{{failOnJsErrors}}} should be changed with {{{skipJsErrors}}} here

AlexanderMoskovkin · 2015-10-19T09:29:09Z

/r-

testcafe-build-bot · 2015-10-19T12:45:44Z

❌ Tests for the commit cb0cae6 have failed. See details.

testcafe-build-bot · 2015-10-19T13:01:14Z

✅ Tests for the commit 0302899 have passed. See details.

inikulin · 2015-10-19T13:03:48Z

FPR

AlexanderMoskovkin · 2015-10-20T09:42:48Z

lgtm

it works nice on my side

kirovboris · 2015-10-20T10:20:04Z

lgtm

testcafe-build-bot · 2015-10-20T10:38:44Z

❌ Tests for the commit f4231d8 have failed. See details.

testcafe-build-bot · 2015-10-20T11:33:05Z

✅ Tests for the commit 3622661 have passed. See details.

inikulin · 2015-10-21T07:44:42Z

ping @churkin

churkin · 2015-10-21T07:58:13Z

lgtm

churkin · 2015-10-21T07:59:16Z

Waiting for @VasilyStrelyaev

VasilyStrelyaev · 2015-10-21T10:08:19Z

src/cli/argument-parser.js

+            .option('-b, --list-browsers', 'output the available browser aliases')
+            .option('-r, --reporter <name>', 'specify the reporter type to use')
+            .option('-p, --report-path <path>', 'specify the path to which the report file should be saved')
+            .option('-s, --screenshots <path>', 'enable screenshot capturing and specify the path to save them to')


oops... 'them' doesn't relate to anything anymore...
enable screenshot capturing and specify the path to save the screenshots to

VasilyStrelyaev · 2015-10-21T10:10:57Z

/r-

testcafe-build-bot · 2015-10-21T11:22:31Z

✅ Tests for the commit 3520ca3 have passed. See details.

VasilyStrelyaev · 2015-10-21T11:27:10Z

lgtm

Implement CLI (closes #105)

inikulin changed the title ~~Implement CLI~~ Implement CLI (closes #105) Oct 16, 2015

kirovboris reviewed Oct 16, 2015
View reviewed changes

AlexanderMoskovkin closed this Oct 16, 2015

AlexanderMoskovkin reopened this Oct 16, 2015

VasilyStrelyaev reviewed Oct 16, 2015
View reviewed changes

AlexanderMoskovkin reviewed Oct 19, 2015
View reviewed changes

VasilyStrelyaev reviewed Oct 21, 2015
View reviewed changes

Implement CLI (closes #105)

3520ca3

VasilyStrelyaev added a commit that referenced this pull request Oct 21, 2015

Merge pull request #118 from inikulin/cli

cf35a75

Implement CLI (closes #105)

VasilyStrelyaev merged commit cf35a75 into DevExpress:master Oct 21, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement CLI (closes #105) #118

Implement CLI (closes #105) #118

inikulin commented Oct 16, 2015

testcafe-build-bot commented Oct 16, 2015

kirovboris Oct 16, 2015

inikulin Oct 16, 2015

kirovboris commented Oct 16, 2015

kirovboris commented Oct 16, 2015

inikulin commented Oct 16, 2015

VasilyStrelyaev Oct 16, 2015

testcafe-build-bot commented Oct 16, 2015

VasilyStrelyaev commented Oct 16, 2015

VasilyStrelyaev Oct 16, 2015

VasilyStrelyaev Oct 16, 2015

VasilyStrelyaev commented Oct 16, 2015

AlexanderMoskovkin commented Oct 16, 2015

inikulin commented Oct 16, 2015

AlexanderMoskovkin Oct 19, 2015

inikulin Oct 19, 2015

AlexanderMoskovkin commented Oct 19, 2015

testcafe-build-bot commented Oct 19, 2015

testcafe-build-bot commented Oct 19, 2015

inikulin commented Oct 19, 2015

AlexanderMoskovkin commented Oct 20, 2015

kirovboris commented Oct 20, 2015

testcafe-build-bot commented Oct 20, 2015

testcafe-build-bot commented Oct 20, 2015

inikulin commented Oct 21, 2015

churkin commented Oct 21, 2015

churkin commented Oct 21, 2015

VasilyStrelyaev Oct 21, 2015

VasilyStrelyaev commented Oct 21, 2015

testcafe-build-bot commented Oct 21, 2015

VasilyStrelyaev commented Oct 21, 2015

Implement CLI (closes #105) #118

Implement CLI (closes #105) #118

Conversation

inikulin commented Oct 16, 2015

testcafe-build-bot commented Oct 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirovboris commented Oct 16, 2015

kirovboris commented Oct 16, 2015

inikulin commented Oct 16, 2015

Choose a reason for hiding this comment

testcafe-build-bot commented Oct 16, 2015

VasilyStrelyaev commented Oct 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VasilyStrelyaev commented Oct 16, 2015

AlexanderMoskovkin commented Oct 16, 2015

inikulin commented Oct 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexanderMoskovkin commented Oct 19, 2015

testcafe-build-bot commented Oct 19, 2015

testcafe-build-bot commented Oct 19, 2015

inikulin commented Oct 19, 2015

AlexanderMoskovkin commented Oct 20, 2015

kirovboris commented Oct 20, 2015

testcafe-build-bot commented Oct 20, 2015

testcafe-build-bot commented Oct 20, 2015

inikulin commented Oct 21, 2015

churkin commented Oct 21, 2015

churkin commented Oct 21, 2015

Choose a reason for hiding this comment

VasilyStrelyaev commented Oct 21, 2015

testcafe-build-bot commented Oct 21, 2015

VasilyStrelyaev commented Oct 21, 2015