Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCafe should not emulate touch events for touch monitors #984

Closed
AlexanderMoskovkin opened this issue Nov 23, 2016 · 2 comments · Fixed by #1077
Closed

TestCafe should not emulate touch events for touch monitors #984

AlexanderMoskovkin opened this issue Nov 23, 2016 · 2 comments · Fixed by #1077
Assignees
@helen-dikareva
Labels
API MODIFICATION LEVEL: non-breaking changes AREA: client AREA: server !IMPORTANT! STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: API SYSTEM: CLI A command-line interface issue. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).
Milestone
Sprint #3

Comments

@AlexanderMoskovkin
Copy link
Contributor

Are you requesting a feature or reporting a bug?

feature

What is the current behavior?

TestCafe switches in touch mode not only for testing in mobiles and tablets but in laptops and desktops with a monitor that supports touch events. But usually you expect to see mouse behavior when testing on a desktop.

What is the expected behavior?

I propose to switch in touch mode in desktops only if the --touch-mode flag enabled.

How would you reproduce the current behavior (if this is a bug)?

The problem is reproduced on the http://demos.devexpress.com/bootstrap/GridView/Overview.aspx page.
On the original page you can drag a column header with mouse but can't do it via touch events. So it's impossible to test this functionality on desktop with touch-monitor because TestCafe runs tests only with touch mode in this case.

/cc @inikulin @helen-dikareva
@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #3 milestone Dec 8, 2016
@AlexanderMoskovkin AlexanderMoskovkin self-assigned this Dec 9, 2016
helen-dikareva added a commit to helen-dikareva/testcafe-phoenix that referenced this issue Dec 13, 2016
@helen-dikareva
touch-mode option added (closes DevExpress#984)
ea3fd79
helen-dikareva added a commit to helen-dikareva/testcafe-phoenix that referenced this issue Dec 15, 2016
@helen-dikareva
touch-mode option added (closes DevExpress#984)
1e3f3b3
@helen-dikareva helen-dikareva changed the title Add test run --touch-mode flag TestCafe should not emulate touch events for touch monitors Dec 15, 2016
@helen-dikareva
Copy link
Collaborator

After discussion about touch-mode option we decided just not to emulate touch events for touch monitors (mouse events'll be emulated in this case)

@helen-dikareva helen-dikareva mentioned this issue Dec 15, 2016
Closed
helen-dikareva added a commit to helen-dikareva/testcafe-phoenix that referenced this issue Dec 16, 2016
@helen-dikareva
touch-mode option added (closes DevExpress#984)
1071d15
@AlexanderMoskovkin AlexanderMoskovkin mentioned this issue Dec 19, 2016
Merged
@AlexanderMoskovkin AlexanderMoskovkin added TYPE: bug The described behavior is considered as wrong (bug). and removed TYPE: proposal labels Jan 12, 2017
@lock
Copy link

lock bot commented Mar 29, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 29, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@helen-dikareva @kirovboris
touch-mode option added (closes DevExpress#984) (DevExpress#1052)
c91c3b1 
* touch-mode option added (closes DevExpress#984)

* rollback touch-mode option

* hammerhead updated

* is-touch-device.js moved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@helen-dikareva helen-dikareva

Labels
API MODIFICATION LEVEL: non-breaking changes AREA: client AREA: server !IMPORTANT! STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: API SYSTEM: CLI A command-line interface issue. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Milestone
Sprint #3
Development

Successfully merging a pull request may close this issue.

Bump version AlexanderMoskovkin/testcafe
2 participants
@helen-dikareva @AlexanderMoskovkin