Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable video recording in docker image #3572

Closed
helmut-lang opened this issue Mar 16, 2019 · 9 comments
Closed

Enable video recording in docker image #3572

helmut-lang opened this issue Mar 16, 2019 · 9 comments
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. STATE: Need improvement A minor issue that can't be treated as a bug.
Milestone

Comments

@helmut-lang
Copy link

Right now it is not possible to use the new video recording feature #2151 with the testcafe docker image.
Running the docker image with the --video parameter causes an error:

ERROR Unable to locate the FFmpeg executable required to record videos. Do one of the following:

* add the FFmpeg installation directory to the PATH environment variable,
* specify the path to the FFmpeg executable in the FFMPEG_PATH environment variable or the ffmpegPath video option,
* install the @ffmpeg-installer/ffmpeg package from npm.

Type "testcafe -h" for help.

What is your Test Scenario?

When running tests on a CI/CD system using the testcafe docker image, videos are helpful to investigate failing tests.

What are you suggesting?

As far as I've seen, the only thing missing to make this work is adding the ffmpeg package to the docker image. I've tested this solution and was able to record videos, as soon as the ffmpeg package was installed during image creation.

What alternatives have you considered?

--

Additional context

--

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 16, 2019
helmut-lang added a commit to helmut-lang/testcafe that referenced this issue Mar 16, 2019
@AndreyBelym AndreyBelym added the TYPE: bug The described behavior is considered as wrong (bug). label Mar 18, 2019
@AndreyBelym AndreyBelym added this to the Sprint #30 milestone Mar 18, 2019
@AndreyBelym AndreyBelym removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 18, 2019
@AndreyBelym AndreyBelym modified the milestones: Sprint #30, Sprint #31 Apr 2, 2019
@afifsohaili
Copy link

https://hub.docker.com/r/afifsohaili/testcafe-ffmpeg I extended the original image, adding ffmpeg. We can use this until testcafe builds the new docker image.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Apr 5, 2019
@AndreyBelym
Copy link
Contributor

I apologize for the delay, we are waiting for our lawyer to approve including ffmpeg to our image, looks like the licensing rules are unclear about it.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Apr 5, 2019
@AndreyBelym AndreyBelym modified the milestones: Sprint #31, Sprint #32 Apr 17, 2019
@AndreyBelym AndreyBelym added STATE: Need improvement A minor issue that can't be treated as a bug. and removed TYPE: bug The described behavior is considered as wrong (bug). labels May 7, 2019
@AndreyBelym AndreyBelym modified the milestones: Sprint #32, Planned May 7, 2019
@franciscolosardo
Copy link

Hey! Did you try using this in your package.json??
"@ffmpeg-installer/ffmpeg": "^1.0.20",
Try to add that to your dependencies in package.json and do an npm i before running the tests..

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 12, 2019
@AndreyBelym AndreyBelym removed the STATE: Need response An issue that requires a response or attention from the team. label Nov 12, 2019
@tbinna
Copy link

tbinna commented Mar 21, 2020

@AndreyBelym any update on this?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 21, 2020
@LavrovArtem
Copy link
Contributor

@tbinna
Currently, we cannot provide any estimates regarding this issue.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 23, 2020
@AlexSkorkin AlexSkorkin added STATE: Need response An issue that requires a response or attention from the team. and removed STATE: Need response An issue that requires a response or attention from the team. labels Mar 24, 2020
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Apr 28, 2020
@prudhvidandamudi
Copy link

Hey! Did you try using this in your package.json??
"@ffmpeg-installer/ffmpeg": "^1.0.20",
Try to add that to your dependencies in package.json and do an npm i before running the tests..

did this workaround work?

@AlexKamaev
Copy link
Contributor

@prudhvidandamudi
I suppose this workaround will not work because the package.json file is located in the project, not in the docker container.

Unfortunately, I have to close this issue. License restrictions do not allow us to install the @FFmpeg package in the official TestCafe image.

Please use the first workaround suggested above: build your own docker image based on the official image as @afifsohaili mentioned.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Apr 29, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. STATE: Need improvement A minor issue that can't be treated as a bug.
Projects
None yet
Development

No branches or pull requests

9 participants