-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestCafe shouldn't start remote browsers before compiling tests #3219
Comments
async createRunnableConfiguration () {
const reporterPlugins = this._getReporterPlugins();
// NOTE: If a user forgot to specify a browser, but has specified a path to tests, the specified path will be
// considered as the browser argument, and the tests path argument will have the predefined default value.
// It's very ambiguous for the user, who might be confused by compilation errors from an unexpected test.
// So, we need to retrieve the browser aliases and paths before tests compilation.
const browserInfo = await this._getBrowserInfo();
if (this._canUseParallelBootstrapping(browserInfo))
return { reporterPlugins, ...await this._bootstrapParallel(browserInfo) };
return { reporterPlugins, ...await this._bootstrapSequence(browserInfo) };
} I have found following comment explain why you make this choice. I don't think it a good reason to do it this way since it will waste browser resources when you running testcafe in CI/CD pipeline. |
Here is the trouble maker and a simple fix: https://github.com/DevExpress/testcafe/pull/3221/files |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow. |
What is your Test Scenario?
Using testcafe to run hundreds of tests on selenium-grid
What is the Current behavior?
selenium webdriver throw Timeout when cases compile didn't finish with BrowsersTimeout.
The reason for this error is clear. We are running our cases on selenium-grid for a long time. After upgrade to 0.23.x, we found that testcafe try to open browsers before cases compile. We will start a async task to sending heartbeats to selenium-grid to keep browsers open. But compile cases will block this tasks. It's ok when little files to compile, but it become a problem when number of cases is large. I hope we should follow the logic of version previous 0.23, which will open browsers after compile.
What is the Expected behavior?
open browser after compile success
What is your web application and your TestCafe test code?
Your website URL (or attach your complete example):
Your complete test code (or attach your test files):
Your complete test report:
Screenshots:
Steps to Reproduce:
Your Environment details:
The text was updated successfully, but these errors were encountered: