Request hook added multiple times when using filter rule

[andrzej-woof]

Are you requesting a feature or reporting a bug?

Bug

What is the current behavior?

If I initialize hook without filter like const hook = new RequestLogger(); then onRequest and onResponse are executed only once with running tests.
But adding filter function seems like attaching new hook with each executed test.

const filterFunction = function (request) {
    return !/^https?:\/\/\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}/.test(request.url);
};

const hook = new RequestLogger(filterFunction);
fixture('Test').requestHooks(hook);

----

import { RequestHook } from 'testcafe';

export class RequestLogger extends RequestHook {
    constructor(requestFilterRuleInit) {
        super(requestFilterRuleInit, DEFAULT_OPTIONS);
    }

    onRequest(event) {
       // This get's called as many times as number executed tests in run
    }

    onResponse(event) {
       // This get's called as many times as number executed tests in run
  }
}

What is the expected behavior?

I would expect that since it's the same const hook it won't get attached more than once.

How would you reproduce the current behavior (if this is a bug)?

See below

Provide the test code and the tested page URL (if applicable)

https://github.com/andrzej-kodify/testcafe-requesthook-bug

Specify your

• operating system: OSX
• testcafe version: 0.20.5
• node.js version: v10.5.0

[miherlosev]

Hi @andrzej-kodify
To collect request/response info, use a built-in RequestLogger class.
If RequestLogger doesn't have the required functionality, clarify your use case and we will try to help you.

[andrzej-woof]

Hi @miherlosev
I want to process requests by adding custom headers, logging them in real time, etc.
But other than that shouldn't it just work since creating custom hooks is described in official docs https://devexpress.github.io/testcafe/documentation/test-api/intercepting-http-requests/creating-a-custom-http-request-hook.html ?

[miherlosev]

@andrzej-kodify

I've investigated the example and found the reason of the problem:
onRequest and onResponse methods were called twice for a single request with 204 http status code.
It's a bug.

[miherlosev]

I'm working on this

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.