-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent situations when request logger tries to stringify a body that is not logged #2555
Comments
We already have a code that handles this case - https://github.com/DevExpress/testcafe/blob/master/src/api/request-hooks/request-logger.js#L31. Problem is in |
An additional reason is that RequestHookConfigureAPIError is an instance of |
I'm working on this |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow. |
…DevExpress#2603) * tmp * fix 'wrong callsite for RequestHooks errors' (close DevExpress#2555)
E. g. when passing
{ logRequestBody: false, stringifyRequestBody: true}
to a logger. We can throw an error in this case or just ignore thestringify
options. We also should state this situation in the docs.The text was updated successfully, but these errors were encountered: