error TS7006: Parameter 'req' implicitly has an 'any' type

[hdorgeval]

Are you requesting a feature or reporting a bug?

Bug

What is the current behavior?

In TypeScript project, tsc will produce the following errors (due to the "noImplicitAny": true in the tsc configuration file):

node_modules/testcafe/ts-defs/index.d.ts(921,54): error TS7006: Parameter 'req' implicitly has an 'any' type.
node_modules/testcafe/ts-defs/index.d.ts(921,59): error TS7006: Parameter 'res' implicitly has an 'any' type.
node_modules/testcafe/ts-defs/index.d.ts(928,40): error TS7006: Parameter 'req' implicitly has an 'any' type.
node_modules/testcafe/ts-defs/index.d.ts(928,45): error TS7006: Parameter 'res' implicitly has an 'any' type.
node_modules/testcafe/ts-defs/index.d.ts(1573,73): error TS7006: Parameter 'req' implicitly has an 'any' type.
node_modules/testcafe/ts-defs/index.d.ts(1573,78): error TS7006: Parameter 'res' implicitly has an 'any' type.

tsc runs well after doing the following modifications:

interface RequestMock {
    /**
     * Specifies requests to intercept
     * @param filter - Specifies which requests should be mocked with a response that follows in the `respond` method.
     */
    onRequestTo(filter: string | RegExp | object | ((req: any, res: any) => boolean)): RequestMock;
    /**
     * Specifies the mocked response.
     * @param body - The mocked response body.
     * @param statusCode - The response status code.
     * @param headers - Custom headers added to the response in the property-value form.
     */
    respond(body?: object | string | ((req: any, res: any) => any), statusCode?: number, headers?: object): RequestMock;
}

export function RequestLogger(filter?: string | RegExp | object | ((req: any, res: any) => boolean), options?: RequestLoggerOptions): RequestLogger;

What is the expected behavior?

How would you reproduce the current behavior (if this is a bug)?

Provide the test code and the tested page URL (if applicable)

Tested page URL:

Test code

Specify your

• operating system: Windows 10
• testcafe version: 0.20.3
• node.js version: v10.1.0
• typescript: 2.6.1
• tsconfig.json

    /* Strict Type-Checking Options */
    "strict": true,                   
    "noImplicitAny": true,            
    "strictNullChecks": true,         
    "strictFunctionTypes": true,      
    "noImplicitThis": true,           
    "alwaysStrict": true,             

[AndreyBelym]

Hi @hdorgeval, thanks for sharing this issue! I think that TestCafe definitions must pass the strictest typechecks, so it's a bug. I will fix definitons and write a test. Right now you have to add "skipLibCheck": true to your tsconfig.json to keep strict typechecking for your code, and disabling them for TestCafe definitions.

[hdorgeval]

Hi @AndreyBelym, thank you for your answer. It's always a pleasure to learn something new from people like you. Now, thank's to you, I fully understand the purpose of the skipLibCheck toggle.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.