Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot flexibility request #1602

Closed
ClaytonAstrom opened this issue Jul 10, 2017 · 2 comments
Closed

Screenshot flexibility request #1602

ClaytonAstrom opened this issue Jul 10, 2017 · 2 comments
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Milestone

Comments

@ClaytonAstrom
Copy link

Are you requesting a feature or reporting a bug?

Feature

What is the current behavior?

Screenshot naming conventions are very restricted, command line parameter -S has no control at all.

What is the expected behavior?

  1. Screenshots should have flexible naming conventions. For example, Junit Attachment Plugin uses the classname xml attribute to associate the artifacts with the package, or uses absolute references

  2. Fixtures and/or tests should have the ability to individually take screenshots on fail. Maybe a hook that can be defined per test? If I have a fixture with:

    test("Test A", async => {});
    test("Test B", async => {});
    test("Test C", async => {});

    Then I should be able to specify which tests I want to take a screenshot on failure. Example:

    test("Test A", async => {});
    test
      .screenShotOnFail(
    	//Some kind of path structure here maybe?      
      )
      ("Test B", async => {});
    test("Test C", async => {});

Specify your

  • operating system: Windows 7
  • testcafe version: 0.16.0
  • node.js version: 6.10.1

Similar issues: #1515 and #1595

@AlexanderMoskovkin
Copy link
Contributor

closed in favor of #2152

miherlosev added a commit that referenced this issue Jul 6, 2018
* Screenshot file pattern

* refactor test constrants

* small refactoring

* renames

* don't correct file path for custom file path

* try to fix tests2

* revert back correct file path for custom path

* revert dedent module

* fix review issues
@AndreyBelym AndreyBelym added TYPE: enhancement The accepted proposal for future implementation. and removed TYPE: proposal labels Feb 6, 2019
@lock
Copy link

lock bot commented Mar 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
…Express#1974, DevExpress#1975) (DevExpress#2562)

* Screenshot file pattern

* refactor test constrants

* small refactoring

* renames

* don't correct file path for custom file path

* try to fix tests2

* revert back correct file path for custom path

* revert dedent module

* fix review issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Development

No branches or pull requests

3 participants