Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve waiting for element logic #1521

Closed
3 tasks done
AlexanderMoskovkin opened this issue Jun 8, 2017 · 2 comments · Fixed by #1582
Closed
3 tasks done

Improve waiting for element logic #1521

AlexanderMoskovkin opened this issue Jun 8, 2017 · 2 comments · Fixed by #1582
Assignees
Labels
AREA: client STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Milestone

Comments

@AlexanderMoskovkin
Copy link
Contributor

AlexanderMoskovkin commented Jun 8, 2017


Here is a test on DevExpress ASP.NET Web Dashboard Demo:

test.page('https://demos.devexpress.com/Dashboard')('Test', async t => {
    await t
        .click(Selector('span').withText('Edit in Designer'))
        .click('.dx-dashboard-designer-menu-button')
        .click(Selector('li').withText('Data Sources'))
        .click(Selector('.dx-dashboard-datasource-list-action').withText('Add'))
        .click(Selector('span').withText('Cancel'))
        .click(Selector('.dx-dashboard-datasource-list-action').withText('Add'));
});

To make it passed it necessary to add some waits between steps. We should check why we don't wait for elements here automatically.

#1482 - it's one more example

@AlexanderMoskovkin AlexanderMoskovkin added AREA: client TYPE: enhancement The accepted proposal for future implementation. labels Jun 8, 2017
@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #8 milestone Jun 8, 2017
@AlexanderMoskovkin AlexanderMoskovkin self-assigned this Jun 8, 2017
@AlexanderMoskovkin
Copy link
Contributor Author

I'm working on this

AlexanderMoskovkin added a commit that referenced this issue Jul 20, 2017
* Implement waiting element login inside automations (closes #1185)

* add tests and spike implementation

* SelectChildAutomation small refactoring

* Click automation refactoring

* DblClick, Hover, RClick refactored

* Drag refactored

* Select action refactoring. Fix tests

* Remove redundant files

* Fix bootstrap case. Fix "pointer-events: none" case.

* Roll back "pointer-events: none" case. Fix svg case in IE

* Show status bar

* Minor refactoring

* Fix test

* Fix test

* Add tests for all automations

* Fix remarks

* Fix remarks

* Fix tests
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Jul 24, 2017
AlexanderMoskovkin added a commit that referenced this issue Jul 25, 2017
* Avoid waiting for a fixed element (follow up #1521)

* Fix `clientPositionChangedAfterMoving` calculation
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Jul 25, 2017
…ress#1646)

* Avoid waiting for a fixed element (follow up DevExpress#1521)

* Fix `clientPositionChangedAfterMoving` calculation
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
…s#1582)

* Implement waiting element login inside automations (closes DevExpress#1185)

* add tests and spike implementation

* SelectChildAutomation small refactoring

* Click automation refactoring

* DblClick, Hover, RClick refactored

* Drag refactored

* Select action refactoring. Fix tests

* Remove redundant files

* Fix bootstrap case. Fix "pointer-events: none" case.

* Roll back "pointer-events: none" case. Fix svg case in IE

* Show status bar

* Minor refactoring

* Fix test

* Fix test

* Add tests for all automations

* Fix remarks

* Fix remarks

* Fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: client STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant