Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide all toolbars when taking screenshots #1445

Closed
mjhea0 opened this issue Apr 24, 2017 · 5 comments
Closed

Hide all toolbars when taking screenshots #1445

mjhea0 opened this issue Apr 24, 2017 · 5 comments
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Milestone
Sprint #10

Comments

@mjhea0
Copy link

mjhea0 commented Apr 24, 2017

Are you requesting a feature or reporting a bug?

feature request

What is the current behavior?

all toolbars are displayed when a screenshot is taken

What is the expected behavior?

remove all toolbars (run chrome from application mode)

Specify your

  • operating system: OS-X 10.11.6
  • testcafe version: 0.14.0
  • node.js version: 7.9.0
@AlexanderMoskovkin AlexanderMoskovkin self-assigned this Apr 25, 2017
@AlexanderMoskovkin
Copy link
Contributor

Hi,

Thanks for the report, we should think out it thoroughly. If we will create screenshots without browser toolbars it can be a breaking change for someone.

As a workaround you can run chrome in application mode via browser arguments:
testcafe "chrome --kiosk" test.js
(quit the running chrome before try it)

@mjhea0
Copy link
Author

mjhea0 commented Apr 25, 2017

The problem with application mode is that debugging is difficult (if not impossible). I don't believe there is a way to open dev tools or toggle application mode if a breakpoint is added.

This issue seems related to #1357.

The use case for me is for visual regression testing. Since the address is different for each test, there will always be a regression. Perhaps a flag that removes the testcafe UI bar and does not include the address bar on screenshots...

@mjhea0
Copy link
Author

mjhea0 commented Apr 26, 2017

Also, curious if you know of anyone that has added on a visual regression feature to testcafe? Looking at using https://github.com/mapbox/pixelmatch to compare the images. Writing a few scripts now to incorporate into the testing workflow.

@inikulin
Copy link
Contributor

@mjhea0 We have #1207. We even had had a long in person discussion about original proposal and decided to drastically change proposed approach afterwards. Discussion should have been documented by @kirovboris. However, unfortunately I can't find any notes 😞 . You can add 👍 to the #1207 so we'll know that there is a demand for the feature.

@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #10 milestone Nov 24, 2017
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Nov 29, 2017
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
15bf70c
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Nov 29, 2017
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
40e5c52
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Dec 6, 2017
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
2db7b19
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Dec 27, 2017
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
4b3c912
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Feb 6, 2018
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
c2d38fd
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Feb 6, 2018
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
64311a8
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Feb 13, 2018
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
e3d2858
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Feb 15, 2018
@AndreyBelym
Implement screenshots cropping to page view (closes DevExpress#1445)
22fab69
@AlexanderMoskovkin AlexanderMoskovkin mentioned this issue Feb 19, 2018
Merged
@AndreyBelym AndreyBelym added TYPE: enhancement The accepted proposal for future implementation. and removed TYPE: proposal labels Feb 6, 2019
@lock
Copy link

lock bot commented Mar 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@AndreyBelym @kirovboris
Crop screenshots to a page and element area (closes DevExpress#1445 c…
e2c8b60 
…loses DevExpress#1496, closes DevExpress#2000) (DevExpress#2026)

* Implement screenshots cropping to page view (closes DevExpress#1445)

* Fix remarks

* Fix functional test

* Fix client tests

* Fix remarks

* Fix assertions in functional test

* Update index.d.ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Milestone
Sprint #10
Development

No branches or pull requests
4 participants
@inikulin @mjhea0 @AndreyBelym @AlexanderMoskovkin