Skip to content

Commit

Permalink
1
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexKamaev committed Apr 18, 2018
1 parent 98b99a6 commit e35d579
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 10 deletions.
10 changes: 5 additions & 5 deletions Gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ gulp.task('client-scripts', ['client-scripts-bundle'], function () {
.src(script.wrapper)
.pipe(mustache({ source: fs.readFileSync(script.src).toString() }))
.pipe(rename(path.basename(script.src)))
.pipe(gulpif(!util.env.dev, uglify()))
// .pipe(gulpif(!util.env.dev, uglify()))
.pipe(gulp.dest(path.dirname(script.src)));
}));
});
Expand Down Expand Up @@ -223,7 +223,7 @@ gulp.task('client-scripts-bundle', ['clean'], function () {
return { code: transformed.code.replace(/^('|")use strict('|");?/, '') };
}
}))
.pipe(gulpif(!util.env.dev, uglify()))
// .pipe(gulpif(!util.env.dev, uglify()))
.pipe(gulp.dest('lib'));
});

Expand Down Expand Up @@ -270,7 +270,7 @@ gulp.task('ts-definitions', ['clean'], function () {
});

gulp.task('fast-build', ['server-scripts', 'client-scripts', 'styles', 'images', 'templates', 'ts-definitions']);
gulp.task('build', ['lint', 'fast-build']);
gulp.task('build', ['fast-build']);

// Test
gulp.task('test-server', ['build'], function () {
Expand Down Expand Up @@ -592,7 +592,7 @@ function testFunctional (fixturesDir, testingEnvironmentName, browserProviderNam
.pipe(mocha({
ui: 'bdd',
reporter: 'spec',
timeout: typeof v8debug === 'undefined' ? 30000 : Infinity // NOTE: disable timeouts in debug
timeout: typeof v8debug === 'undefined' ? 3000000 : Infinity // NOTE: disable timeouts in debug
}));
}

Expand All @@ -604,7 +604,7 @@ gulp.task('test-functional-travis-mobile', ['build'], function () {
return testFunctional('test/functional/fixtures', functionalTestConfig.testingEnvironmentNames.mobileBrowsers, functionalTestConfig.browserProviderNames.browserstack);
});

gulp.task('test-functional-local', ['build'], function () {
gulp.task('test-functional-local', [], function () {
return testFunctional('test/functional/fixtures', functionalTestConfig.testingEnvironmentNames.localBrowsers);
});

Expand Down
2 changes: 1 addition & 1 deletion src/browser/connection/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class BrowserConnection extends EventEmitter {
constructor (gateway, browserInfo, permanent) {
super();

this.HEARTBEAT_TIMEOUT = 2 * 60 * 1000;
this.HEARTBEAT_TIMEOUT = 20000 * 60 * 1000;

this.id = BrowserConnection._generateId();
this.jobQueue = [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,9 @@ $(document).ready(function () {
var fixedText = 'Test' + String.fromCharCode(160) + 'me' + String.fromCharCode(160) + 'all!';
var inputEventRaisedCount = 0;

// NOTE IE11 does not raise input event on contenteditable element
var expectedInputEventRaisedCount = !browserUtils.isIE11 ? 12 : 0;

$el = $('#2');

function onInput () {
Expand All @@ -454,7 +457,7 @@ $(document).ready(function () {
.then(function () {
checkSelection($el, $el[0].childNodes[2], 4 + text.length, $el[0].childNodes[2], 4 + text.length);
equal($.trim($el[0].childNodes[2].nodeValue), 'with' + fixedText + ' br');
equal(inputEventRaisedCount, 12);
equal(inputEventRaisedCount, expectedInputEventRaisedCount);
$el.unbind('input', onInput);

startNext();
Expand All @@ -465,6 +468,9 @@ $(document).ready(function () {
var text = 'Test';
var inputEventRaisedCount = 0;

// NOTE IE11 does not raise input event on contenteditable element
var expectedInputEventRaisedCount = !browserUtils.isIE11 ? 4 : 0;

$el = $('#8');

function onInput () {
Expand All @@ -479,7 +485,7 @@ $(document).ready(function () {
.run()
.then(function () {
equal($.trim($el[0].textContent), text);
equal(inputEventRaisedCount, 4);
equal(inputEventRaisedCount, expectedInputEventRaisedCount);
$el.unbind('input', onInput);

startNext();
Expand Down
7 changes: 5 additions & 2 deletions test/functional/fixtures/regression/gh-1956/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ describe('Should support TextInput event[Regression](GH-1956)', function () {
'Prevent Input event on TextInput when type to input element IE11/Firefox',
{ only: [ 'ie', 'firefox', 'firefox-osx' ], shouldFail: true })
.catch(function (errs) {
expect(errs['ie'][0]).contains('Input event has raised');
expect(errs['firefox'][0]).contains('Input event has raised');
var errors = [ errs['ie'], errs['firefox'] ].filter(err => err);

errors.forEach(err => {
expect(err[0]).contains('Input event has raised');
});
});
});

Expand Down

0 comments on commit e35d579

Please sign in to comment.