Skip to content

Commit

Permalink
Use overflow:hidden for shadowui root(closes #1138) (#1145)
Browse files Browse the repository at this point in the history
  • Loading branch information
AndreyBelym authored and AlexanderMoskovkin committed Jan 19, 2017
1 parent 77ad9f7 commit 1cb440a
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/client/ui/styles.less
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
left: 0px;
top: 0px;
margin: 0 !important;
overflow: visible;
overflow: hidden;

.layout-default();

Expand Down
19 changes: 19 additions & 0 deletions test/functional/fixtures/regression/gh-1138/pages/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!DOCTYPE html>
<html>
<head>
<title>GH-1138</title>
<style>
#target {
padding: 0px 0px 0px 0px;
bottom: 0px;
height: 20px;
right: 0px;
width: 80px;
position: absolute;
}
</style>
</head>
<body topmargin="0" leftmargin="0" bottommargin="0" rightmargin="0">
<div id="target" onclick="this.textContent = 'It works'" tabIndex="1">Click Me</div>
</body>
</html>
5 changes: 5 additions & 0 deletions test/functional/fixtures/regression/gh-1138/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
describe('[Regression](GH-1138)', function () {
it('Test should click on target that has moved during the action', function () {
return runTests('testcafe-fixtures/index.test.js', 'Click on element bound to the right bottom corner');
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { Selector } from 'testcafe';

fixture `GH-1138`
.page('http://localhost:3000/fixtures/regression/gh-1138/pages/index.html');

test('Click on element bound to the right bottom corner', async t => {
var target = Selector('#target');

await t
.click(target)
.expect(target.textContent).eql('It works');
});

0 comments on commit 1cb440a

Please sign in to comment.