fix 'Wrong behaviour for window.fetch request called without parameters' (close #939) #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit e17d2c9 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit e17d2c9 have failed. See details: |
|
rebase please |
|
done |
|
❌ Tests for the commit 2d5af7e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 2d5af7e have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit 2d5af7e have passed. See details: |
|
FPR |
LavrovArtem
suggested changes
Nov 17, 2016
| @@ -42,7 +42,13 @@ export default class FetchSandbox extends SandboxBase { | |||
| args[1] = FetchSandbox._processRequestInit(init); | |||
| } | |||
|
|
|||
| static _isValidRequestArgs (args) { | |||
| return typeof args[0] === 'string' || isFetchRequest(args[0]); | |||
| } | |||
There was a problem hiding this comment.
Add new line after this function
|
❌ Tests for the commit ce7f22a have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit ce7f22a have passed. See details: |
|
FPR |
LavrovArtem
approved these changes
Nov 17, 2016
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…rs' (close DevExpress#939) (DevExpress#946) * fix 'Wrong behaviour for window.fetch request called without parameters' (close DevExpress#939) * add new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@churkin @LavrovArtem