Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support non-canonicalised srcset attribute name #2958 #2968

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: support non-canonicalised srcset attribute name #2958 #2968

merged 1 commit into from
Oct 24, 2023

Commits on Oct 24, 2023

  1. fix: support non-canonicalised srcset attribute name DevExpress#2958 

    Some frameworks, like React, use non-canonicalised attribute names. The
spec and browsers allow this, but hammerhead is only checking if the
attribute name without canonicalisation matches `srcset`.

By using the `loweredAttr` for the comparison, hammerhead will be more
accepting of inputs and resolve srcset issues with React projects
(fixes DevExpress#2958).

See facebook/react#10863 for more background.
    @gg-kialo
    gg-kialo committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0cde1d7 View commit details
    Browse the repository at this point in the history