Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internal listeners to unsubscribe when executed (closes DevExpress/testcafe#3652) #1989

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

AndreyBelym
Copy link
Contributor

@AndreyBelym AndreyBelym commented Apr 12, 2019

Closes DevExpress/testcafe#3652.

babel-plugin-transform-for-of-as-array caches an array length when transforming for-of cycles:

for(const x of xs)

// Transformed To

for(var _i = 0, _length = xs.length; i < _length; ++i)

It can throw a runtime exception if an element is deleted from the array inside the cycle's body.

babel/plugin-transform-for-of produces a safer transpiled code:

for(const x of xs)

// Transformed To

for(var _i = 0; i < xs._length; ++i)

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit a208f5e have passed. See details.

@miherlosev miherlosev merged commit 1c0c253 into DevExpress:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when I click on the "Unlock Page" button
3 participants