Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vulnerabilities (gulp, gulp-mocha, gulp-mustache, gulp-if, del) #1642

Merged
merged 7 commits into from
Jun 9, 2018
Merged

fix vulnerabilities (gulp, gulp-mocha, gulp-mustache, gulp-if, del) #1642

merged 7 commits into from
Jun 9, 2018

Conversation

Farfurix
Copy link
Contributor

@Farfurix Farfurix commented Jun 7, 2018 •
edited
Loading

Before:

found 30 vulnerabilities (8 low, 11 moderate, 10 high, 1 critical)

Current:

found 20 vulnerabilities (6 low, 11 moderate, 3 high)

Changes:

  1. Update gulp, gulp-mocha, gulp-mustache, gulp-if, del.
  2. Use gulp-step for gulp tasks
  3. Fix Gulpfile.js
  4. Use gulp-ll-next instead of gulp-ll

npm install --save-dev [email protected]

https://github.com/sindresorhus/del/releases/tag/v2.0.0:

The API now returns a promise instead of accepting a callback function.

And with gulp:

 var gulp = require('gulp');
 var del = require('del');

- gulp.task('clean', function (cb) {
-   del('unicorn.png', cb);
+ gulp.task('clean', function () {
+   return del('unicorn.png');
 });

 gulp.task('default', ['clean']);

Gulp tool window

Before After
gulp-commands-before gulp-commands-after

@Farfurix Farfurix changed the title fix vulnerabilities [WIP] fix vulnerabilities Jun 7, 2018
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 78ed2d7 have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jun 7, 2018

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 78ed2d7 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a5b5d3f have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jun 7, 2018

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a5b5d3f have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jun 7, 2018

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a5b5d3f have failed. See details.

miherlosev
miherlosev requested changes Jun 7, 2018
View reviewed changes
Gulpfile.js
});

gulp.task('client-scripts-bundle', ['clean'], () => {
gulp.step('client-scripts-bundle', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can migrate to gulp 4 using a more simple manner

//Gulp 3
gulp.task('client-scripts', ['client-scripts-bundle'], () => {
});

//Gulp 4
gulp.task('client-scripts', gulp.series(['client-scripts-bundle'], () => {
}));

See https://github.com/gulpjs/gulp/blob/4.0/docs/API.md#gulpseriestasks

Check it and discuss with @AndreyBelym

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @AndreyBelym we decide to use gulp-step.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 8cd7bc2 have passed. See details.

@Farfurix Farfurix changed the title [WIP] fix vulnerabilities fix vulnerabilities Jun 8, 2018
@Farfurix Farfurix changed the title fix vulnerabilities fix vulnerabilities (gulp, gulp-mocha, gulp-mustache, gulp-if, del) Jun 8, 2018
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 1984d7c have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit f8190e9 have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jun 9, 2018

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit f8190e9 have passed. See details.

miherlosev
miherlosev requested changes Jun 9, 2018
View reviewed changes
Gulpfile.js Outdated
@@ -148,12 +138,28 @@ gulp.task('client-scripts-bundle', ['clean'], () => {
.pipe(gulp.dest('./lib/client'));
});

gulp.task('server-scripts', ['clean'], () => {
gulp.step('client-scripts-render', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to gulp.step('client-scripts-processing')

Gulpfile.js Outdated

// Test
gulp.task('test-server', ['build'], () => {
gulp.step('test-server-run', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.step('mocha')

Gulpfile.js Outdated
gulp.watch('./src/**', ['build']);
gulp.task('test-server', gulp.series('build', 'test-server-run'));

gulp.step('test-client-run', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.step('qunit', ()

Gulpfile.js Outdated

gulp.task('test-client-travis', ['build'], () => {
gulp.step('test-client-travis-run', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.step('travis-saucelabs-qunit'

Gulpfile.js Outdated
gulp.task('http-playground', ['set-dev-mode', 'build'], () => {
gulp.task('test-client-travis', gulp.series('build', 'test-client-travis-run'));

gulp.step('http-playground-run', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.step('http-playground-server'

Gulpfile.js Outdated
gulp.task('https-playground', ['set-dev-mode', 'build'], () => {
gulp.task('http-playground', gulp.series('set-dev-mode', 'build', 'http-playground-run'));

gulp.step('https-playground-run', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.step('https-playground-server'

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit bf0dff3 have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jun 9, 2018

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit bf0dff3 have passed. See details.

@Farfurix Farfurix merged commit b0c978e into DevExpress:master Jun 9, 2018
@Farfurix Farfurix deleted the vulnerabilities2 branch June 9, 2018 09:42
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this pull request Feb 28, 2019
@Farfurix @AndreyBelym
fix vulnerabilities (gulp, gulp-mocha, gulp-mustache, gulp-if, del) (D…
8a3de6a 
…evExpress#1642)

* fix vulnerabilities

* update publish-please

* restore publish-please

* gulp-ll-next

* update gulp-ll-next

* update gulp-ll-next

* requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miherlosev miherlosev miherlosev approved these changes

@AndreyBelym AndreyBelym Awaiting requested review from AndreyBelym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Farfurix @testcafe-build-bot @miherlosev