fix Resource with the 304 status code and the 'content-length: x' header does not load (close #1602)
#1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 49a9d0a have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 49a9d0a have failed. See details: |
|
✅ Tests for the commit a9f185c have passed. See details: |
miherlosev
requested changes
Jun 4, 2018
src/request-pipeline/index.js
Outdated
| @@ -96,7 +96,11 @@ const stages = { | |||
| ctx.onResponseEventDataWithoutBody.push({ rule, opts: configureResponseEvent.opts }); | |||
| }); | |||
|
|
|||
| ctx.destRes.pipe(ctx.res); | |||
| if (ctx.contentInfo.isNotModified) | |||
| ctx.res.end(''); | |||
There was a problem hiding this comment.
Can we simplify this to ctx.res.end();
I guess we need do same for requests with processed content too.
|
❌ Tests for the commit f7351b1 have failed. See details: |
miherlosev
approved these changes
Jun 13, 2018
…ader does not load` (close DevExpress#1602)
|
@testcafe-build-bot retest |
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…ader does not load` (close DevExpress#1602) (DevExpress#1638) * fix `Resource with the 304 status code and the 'content-length: x' header does not load` (close DevExpress#1602) * fix tests * fix review issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.