Support https protocol (testcafe #1985) #1590
Conversation
|
❌ Tests for the commit 1911d3b have failed. See details: |
|
Hi @intermike, |
|
❌ Tests for the commit 109d1d6 have failed. See details: |
src/proxy/index.js
Outdated
| }; | ||
| } | ||
|
|
||
| // Proxy | ||
| export default class Proxy extends Router { | ||
| constructor (hostname, port1, port2) { | ||
| constructor (hostname, port1, port2, options) { |
There was a problem hiding this comment.
Set default value for option parameter in constructor:
constructor (hostname, port1, port2, options = {})
src/proxy/index.js
Outdated
|
|
||
| const serverProvider = options.ssl ? https : http; | ||
| const protocol = options.ssl ? 'https:' : 'http:'; | ||
| const serverOptions = { |
There was a problem hiding this comment.
Rename to options.
Because there is no another options in this scope.
|
❌ Tests for the commit 85046e3 have failed. See details: |
| @@ -211,6 +216,12 @@ test('relative path', function () { | |||
| strictEqual(parsedUrl.partAfterHost, 'share?id=1kjQMWh7IcHdTBbTv6otRvCGYr-p02q206M7aR7dmog0'); | |||
| }); | |||
|
|
|||
| test('relative path (https proxy)', function () { | |||
There was a problem hiding this comment.
Change the structure of tests:
module('https proxy protocol');
test('relative path');
test('special pages');
test('http');
|
❌ Tests for the commit a4b18d6 have failed. See details: |
LavrovArtem
changed the title
LavrovArtem
changed the title
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit d7fb324 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 9693b4c have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 9693b4c have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit 9693b4c have passed. See details: |
* run testcafe with https protocol (DevExpress#1985) * fix some places, add `--ssl` option to playground, add tests * make separate tasks * rename tasks * fix tests
No description provided.