Selection setting fixed #1565
Merged
Selection setting fixed #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miherlosev
requested changes
Apr 11, 2018
| @@ -7,6 +7,8 @@ var isIE = browserUtils.isIE; | |||
| var isMobileBrowser = browserUtils.isIOS || browserUtils.isAndroid; | |||
| var browserVersion = browserUtils.version; | |||
|
|
|||
| var IE_FOCUS_TIMEOUT = 100; | |||
There was a problem hiding this comment.
var IE11_FOCUS_TIMEOUT = 100;
| @@ -80,3 +82,89 @@ test('Focus should stay on input with "number" type after setting selection', fu | |||
| strictEqual(document.activeElement, input); | |||
| document.body.removeChild(input); | |||
| }); | |||
|
|
|||
| asyncTest('Focus should not be called during setting selection if conteneditable element has been already focused (TestCafe GH - 2301)', function () { | |||
| var isOldIE = browserUtils.isIE && browserUtils.version < 12; | |||
There was a problem hiding this comment.
Remove the isOldIE variable and use the browserUtils.isIE11 instruction.
|
❌ Tests for the commit b2515cf have failed. See details: |
helen-dikareva
force-pushed
the
select-ce
branch
from
b2515cf
to
73ee44a
Compare
|
❌ Tests for the commit 73ee44a have failed. See details: |
miherlosev
approved these changes
Apr 11, 2018
|
✅ Tests for the commit 4a8ec08 have passed. See details: |
AlexKamaev
approved these changes
Apr 11, 2018
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
* fix * test added * test fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for TestCafe bug