textInput event should be supported correctly #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests for the commit 51e86a2 have passed. See details: |
miherlosev
requested changes
Apr 11, 2018
| _dispatchTextEvent (el, text) { | ||
| const name = browserUtils.isIE ? 'textinput' : 'textInput'; | ||
|
|
||
| let event = null; |
There was a problem hiding this comment.
Specification https://webplatform.github.io/docs/dom/TextEvent/initTextEvent.
Rewrite as
if (nativeMethods.WindowTextEvent && nativeMethods.documentCreateEvent) {
const event = nativeMethods.documentCreateEvent.call(document, 'TextEvent');
const textEventArgs = {
eventType: browserUtils.isIE ? 'textinput' : 'textInput',
...other parameters
};
event.initTextEvent(textEventArgs.eventType, ....);
return this._raiseDispatchEvent(el, event);
}
return null;Also there are few questions about event.initTextEvent(name, true, true, null, text, 0, '') parameters:
nullspecified for window on which this event is occurring. Maybe it should be the current window instead of null?- 0 specified how text is entered. Now it equals
TextEvent.DOM_INPUT_METHOD_UNKNOWN = 0. Maybe we should useTextEvent.DOM_INPUT_METHOD_KEYBOARD = 1? - '' specified the locale name. As I understand it should be the current locale name -
navigator.language.
| @@ -674,3 +674,26 @@ test('wrong type of the blur event (GH-947)', function () { | |||
| eventSimulator.blur(domElement); | |||
| ok(raised); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Add comment that firefox does not support textInput event.
Rename test to text input and place it right after the drag and drop events test.
|
❌ Tests for the commit 5ab2923 have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit 5ab2923 have passed. See details: |
miherlosev
approved these changes
Apr 11, 2018
AlexanderMoskovkin
approved these changes
Apr 12, 2018
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
* [WIP]textInput event should be supported correctly * fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected with DevExpress/testcafe#1956