fix Onclick handler probably doesn't work after click on 'Submit' button in form (close #1291)
#1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton in form` (close DevExpress#1291)
|
❌ Tests for the commit b0ddb62 have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit b0ddb62 have passed. See details: |
|
FPR |
miherlosev
approved these changes
Sep 5, 2017
miherlosev
requested changes
Sep 5, 2017
| @@ -606,3 +606,27 @@ test('document.activeElement when it equals null (GH-1226)', function () { | |||
|
|
|||
| div.parentNode.removeChild(div); | |||
| }); | |||
|
|
|||
| if (!browserUtils.isIE) { | |||
| test('form.action should return element when the form contains element with the "action" attribute name (GH-1291)', function () { | ||
| var form = document.createElement('form'); | ||
| var input = document.createElement('input'); | ||
|
|
There was a problem hiding this comment.
Use native element behaviour to get expected values.
var nativeForm = nativeMethods.createElement....
var nativeInput = nativeMethods.createElement...
|
✅ Tests for the commit e726881 have passed. See details: |
|
FPR |
miherlosev
approved these changes
Sep 6, 2017
helen-dikareva
approved these changes
Sep 6, 2017
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…tton in form` (close DevExpress#1291) (DevExpress#1294) * fix `Onclick handler probably doesn't work after click on 'Submit' button in form` (close DevExpress#1291) * test refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @miherlosev @helen-dikareva