fix Images with style=background-image: url("img.png"); aren't loaded (close #1212)
#1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 30c4782 have failed. See details: |
|
✅ Tests for the commit 34557f8 have passed. See details: |
miherlosev
requested changes
Sep 5, 2017
| @@ -129,6 +129,23 @@ export default class PropertyAccessorsInstrumentation extends SandboxBase { | |||
| return HTML_ELEMENT_TEXT_PROPERTIES[prop]; | |||
| } | |||
|
|
|||
| static _createStyleInstrumentation (property) { | |||
There was a problem hiding this comment.
_createForStyleProperty (property)
src/client/sandbox/native-methods.js
Outdated
| @@ -193,6 +193,22 @@ class NativeMethods { | |||
| if (textAreaValueDescriptor && typeof textAreaValueDescriptor.set === 'function') | |||
| this.textAreaValueSetter = textAreaValueDescriptor.set; | |||
|
|
|||
| // stylesheets | |||
src/client/sandbox/node/window.js
Outdated
| @@ -68,6 +68,29 @@ export default class WindowSandbox extends SandboxBase { | |||
| return String(reason); | |||
| } | |||
|
|
|||
| static _wrapCSSGetPropertyValueIfNecessary (constructor, nativeGetPropertyValue) { | |||
There was a problem hiding this comment.
Rename function parameter to the nativeGetPropertyValueFn
src/client/sandbox/node/window.js
Outdated
| } | ||
| } | ||
|
|
||
| static _wrapCSSSetPropertyIfNecessary (constructor, nativeSetProperty) { |
| cssProperties.forEach(function (prop) { | ||
| var value = 'url(' + url + ')'; | ||
|
|
||
| // NOTE: We cannot get url through 'borderImage' or 'border-image' properties |
There was a problem hiding this comment.
NOTE: If we setup borderImageorborder-imageproperty then it affects aborderImageSource` property.
|
|
||
| el.style[prop] = value; | ||
|
|
||
| var controlValue = el.style[propForChecking]; |
| var value = 'url(' + url + ')'; | ||
|
|
||
| // NOTE: We cannot get url through 'borderImage' or 'border-image' properties | ||
| var propForChecking = prop === 'borderImage' || prop === 'border-image' ? 'borderImageSource' : prop; |
| var url = 'http://some.domain.com/image.png'; | ||
| var proxyUrl = urlUtils.getProxyUrl(url); | ||
|
|
||
| div.style.setProperty('background', 'url(' + url + ')', ''); |
There was a problem hiding this comment.
Add test for non-string url value case
For example:
div.style.setProperty('background', null)
| @@ -375,3 +375,15 @@ test('the constructor field of a function should return a wrapped Function objec | |||
| Function.prototype.toString = nativeToString; | |||
| /*eslint-enable no-extend-native*/ | |||
| }); | |||
|
|
|||
| test('getPropertyValue and setProperty methods of css object should be overridden (GH-1212)', function () { | |||
There was a problem hiding this comment.
Also check style.removeProperty.
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/removeProperty
It should returns non-proxied value.
|
✅ Tests for the commit 797af00 have passed. See details: |
|
FPR |
miherlosev
approved these changes
Sep 5, 2017
|
ping @helen-dikareva |
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…d` (close DevExpress#1212) (DevExpress#1293) * fix `Images with style=background-image: url("img.png"); aren't loaded` (close DevExpress#1212) * renaming * fix tests * fix review's issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @miherlosev @helen-dikareva