fix The document.open function throws an error because document.defaultView returns null (close #1272)
#1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultView returns null` (close DevExpress#1272)
|
✅ Tests for the commit 59a86aa have passed. See details: |
miherlosev
requested changes
Aug 25, 2017
|
|
||
| var iframeDocument = iframe.contentDocument; | ||
| test('should not throw an error when document.defualtView is null', function () { |
There was a problem hiding this comment.
test(should not throw an error when document.defualtView is null (GH-1272))
|
|
||
| strictEqual(nativeMethods.querySelectorAll.call(document, '.' + SHADOW_UI_CLASSNAME.selfRemovingScript).length, 0); | ||
| // NOTE: Without setTimeout the error does not reproduced |
There was a problem hiding this comment.
// NOTE: Without wrapping in 'setTimeout' function the error is not reproduced
miherlosev
approved these changes
Aug 25, 2017
|
✅ Tests for the commit b8fade9 have passed. See details: |
|
ping @churkin |
churkin
approved these changes
Sep 4, 2017
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…ultView returns null` (close DevExpress#1272) (DevExpress#1279) * fix `The document.open function throws an error because document.defaultView returns null` (close DevExpress#1272) * test refactoring * fix review's issues * fix review's issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @miherlosev @churkin