Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammerhead duplicates internal fetch header values #1360

Closed
churkin opened this issue Nov 7, 2017 · 5 comments
Closed

Hammerhead duplicates internal fetch header values #1360

churkin opened this issue Nov 7, 2017 · 5 comments
Assignees
Labels
!IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug

Comments

@churkin
Copy link
Contributor

churkin commented Nov 7, 2017

https://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/fetch.js#L24

Need to chage

  headers.append(XHR_HEADERS.origin, originHeaderValue);
  headers.append(XHR_HEADERS.fetchRequestCredentials, requestCredentials);

to

  headers.set(XHR_HEADERS.origin, originHeaderValue);
  headers.set(XHR_HEADERS.fetchRequestCredentials, requestCredentials);
@ixrock
Copy link

ixrock commented Nov 8, 2017

Is it included in testcafe v0.18.3?

@AlexanderMoskovkin
Copy link
Contributor

@ixrock, no. We'll provide you with a dev version with the fix soon

@AlexanderMoskovkin
Copy link
Contributor

@ixrock, We've just published a dev build with the fix. You can install it with the command:
npm install [email protected] -g

Please let me know does it work properly now on your side.

@ixrock
Copy link

ixrock commented Nov 9, 2017

@AlexanderMoskovkin works fine for me! Thanks.

AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
!IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Development

No branches or pull requests

4 participants