fix `Server shutdown with "Error: Can't set headers after they are se…

…nt." ` (close #937)
DevExpress · Nov 15, 2016 · 9202cba · 9202cba
1 parent 3d567d1
commit 9202cba
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 1 deletion.
diff --git a/src/request-pipeline/destination-request/index.js b/src/request-pipeline/destination-request/index.js
@@ -112,8 +112,11 @@ export default class DestinationRequest extends EventEmitter {
             this._send();
         }
 
-        else if (this._isDNSErr(err))
+        else if (this._isDNSErr(err)) {
+            this._abort();
             this.emit('fatalError', getText(MESSAGE.cantResolveUrl, this.opts.url));
+        }
+
         else
             this.emit('error');
     }

diff --git a/test/client/fixtures/sandbox/code-instrumentation/getters-test.js b/test/client/fixtures/sandbox/code-instrumentation/getters-test.js
@@ -169,6 +169,10 @@ test('document.baseURI (GH-920)', function () {
         }
     };
 
+    documentMock.toString.toString = function () {
+        return 'function test() { [native code] }';
+    };
+
     strictEqual(getProperty(documentMock, 'baseURI'), url);
 });
 

diff --git a/test/server/proxy-test.js b/test/server/proxy-test.js
@@ -229,6 +229,12 @@ describe('Proxy', function () {
             res.end();
         });
 
+        app.get('/wait/:ms', function (req, res) {
+            setTimeout(function () {
+                res.end('text');
+            }, req.params.ms);
+        });
+
         destServer = app.listen(2000);
 
 
@@ -1415,5 +1421,41 @@ describe('Proxy', function () {
             });
         });
 
+        it('Should abort destination request after fatal error (GH-937)', function (done) {
+            var savedReqTimeout      = DestinationRequest.TIMEOUT;
+            var fatalErrorEventCount = 0;
+
+            DestinationRequest.TIMEOUT = 100;
+
+            var destReq = new DestinationRequest({
+                url:      'http://127.0.0.1:2000/wait/150',
+                protocol: 'http:',
+                hostname: '127.0.0.1',
+                host:     '127.0.0.1:2000',
+                port:     2000,
+                path:     '/wait/150',
+                method:   'GET',
+                body:     new Buffer([]),
+                isXhr:    false,
+                headers:  []
+            });
+
+            destReq.on('error', function () {
+            });
+            destReq.on('fatalError', function () {
+                fatalErrorEventCount++;
+            });
+
+            setTimeout(function () {
+                destReq._onError({ message: 'ECONNREFUSED' });
+            }, 50);
+
+            setTimeout(function () {
+                DestinationRequest.TIMEOUT = savedReqTimeout;
+
+                expect(fatalErrorEventCount).eql(1);
+                done();
+            }, 150);
+        });
     });
 });