Allow to pass descriptor into API functions #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churkin
approved these changes
Aug 14, 2017
VasilyStrelyaev
suggested changes
Aug 14, 2017
API.md
Outdated
|
|
||
| | Param | Type | Description | | ||
| | --- | --- | --- | | ||
| | pageTitle | <code>string</code> | The title of the web page opened in the window which descriptor should be retrieved. | |
There was a problem hiding this comment.
| pageTitle | <code>string</code> | The title of the web page opened in a window whose descriptor should be retrieved. |
API.md
Outdated
| Retrieves a platform-specific window descriptor for the window that contains a web page with the specified title. | ||
|
|
||
| **Kind**: global [async](http://tc39.github.io/ecmascript-asyncawait/) function | ||
| **Returns**: <code>object</code> - a platform-specific window descriptor that can be used as a window identifier in some other API functions. |
There was a problem hiding this comment.
**Returns**: <code>object</code> - a platform-specific window descriptor that can be used as a window identifier.
API.md
Outdated
| Checks if the specified browser window is maximized. | ||
|
|
||
| **Kind**: global [async](http://tc39.github.io/ecmascript-asyncawait/) function | ||
| **Returns**: <code>boolean</code> - `true` if the browser window is maximized | ||
|
|
||
| | Param | Type | Description | | ||
| | --- | --- | --- | | ||
| | pageTitle | <code>string</code> | The title of the web page opened in the window to check if this window is maximized. | | ||
| | windowId | <code>string</code> | <code>object</code> | The title of the web page opened in the window or a descriptor returned by findWindow to check if this window is maximized. | |
There was a problem hiding this comment.
| windowId | <code>string</code> | <code>object</code> | The title of the web page opened in the window or a descriptor returned by findWindow. |
VasilyStrelyaev
approved these changes
Aug 14, 2017
|
Please add id of issues that will be closed with this PR |
|
I thought it will be |
AlexanderMoskovkin
approved these changes
Aug 15, 2017
AlexanderMoskovkin
suggested changes
Aug 15, 2017
API.md
Outdated
| @@ -1,9 +1,12 @@ | |||
| ## Functions | |||
|
|
|||
| <dl> | |||
| <dt><a href="#close">async close(pageTitle)</a></dt> | |||
| <dt><a href="#close">async close(windowId)</a></dt> | |||
There was a problem hiding this comment.
API is outdated. Should windowDescriptor
AlexanderMoskovkin
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #128
\cc @AlexanderMoskovkin @churkin @VasilyStrelyaev