🎴 CardView - HeaderFilter - implement #29627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into grids/cardview/main
…e into grids/cardview/main
…e into grids/cardview/main_FilterSync2
wdevfx
reviewed
Apr 16, 2025
packages/devextreme/js/__internal/grids/new/grid_core/filtering/filter_controller.ts
Outdated
Show resolved
Hide resolved
...vextreme/js/__internal/grids/new/grid_core/filtering/filter_visitors/clear_filter_visitor.ts
Outdated
Show resolved
Hide resolved
...vextreme/js/__internal/grids/new/grid_core/filtering/filter_visitors/clear_filter_visitor.ts
Outdated
Show resolved
Hide resolved
...vextreme/js/__internal/grids/new/grid_core/filtering/filter_visitors/clear_filter_visitor.ts
Outdated
Show resolved
Hide resolved
...e/js/__internal/grids/new/grid_core/filtering/filter_visitors/get_applied_filters_visitor.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/controller.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/utils.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/utils.ts
Outdated
Show resolved
Hide resolved
...ages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/view_controller.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/new/grid_core/filtering/utils.ts
Outdated
Show resolved
Hide resolved
pomahtri
reviewed
Apr 17, 2025
| const { headerFilter, filterType } = this.props.column; | ||
|
|
||
| const hasHeaderFilterValue = headerFilter?.filterType === 'exclude' | ||
| const hasHeaderFilterValue = filterType === 'exclude' |
Contributor
There was a problem hiding this comment.
So, we revert change filterType -> headerFilter.filterType?
Maybe then remove change filterValue -> headerFilter.filterValue?
Contributor
Author
There was a problem hiding this comment.
Under discussing with PMs.
pomahtri
approved these changes
Apr 17, 2025
Raushen
merged commit 4a1824d
into
DevExpress:grids/cardview/main
300 of 301 checks passed
Tucchhaa
pushed a commit
to Tucchhaa/DevExtreme
that referenced
this pull request
Apr 18, 2025
pomahtri
pushed a commit
that referenced
this pull request
Apr 22, 2025
pomahtri
pushed a commit
that referenced
this pull request
Apr 22, 2025
marker-dao
pushed a commit
to marker-dao/DevExtreme
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.