This repository was archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Start telemetry earlier and add a timeout #55
Merged
grahamc
merged 6 commits into
main
from
hoverbear/ds-263-telemetry-background-it-and-add-a
Aug 26, 2022
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e0ac993
Add a timeout to telemetry and throw it into a spawn near the start
Hoverbear 37d5d1d
repair join
Hoverbear d59e8a3
No spawn on no telemetry
Hoverbear 2becf4d
Merge branch 'main' into hoverbear/ds-263-telemetry-background-it-and…
Hoverbear 976b3de
Don't send telemetry in registry reqs
Hoverbear b6dcccd
Rework how we detect telemetry options in --help cases
Hoverbear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely nit-picky, so feel free to ignore, but it'd be swell to group std, external, and internal imports near each-other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a rustfmt setting if I recall...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is, but it's not stabilized, sadly: https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#group_imports, rust-lang/rustfmt#5083.