Skip to content

Update to latest Determinate Nix#5

Merged
edolstra merged 3 commits intomainfrom
update-nix
Feb 28, 2026
Merged

Update to latest Determinate Nix#5
edolstra merged 3 commits intomainfrom
update-nix

Conversation

@edolstra
Copy link
Collaborator

@edolstra edolstra commented Feb 28, 2026

Summary by CodeRabbit

  • Refactor
    • Updated wasm plugin function invocation syntax from positional arguments to named-argument form for improved clarity and consistency.
    • Simplified plugin function bindings by removing intermediate variable declarations where applicable.
    • Transitioned wasm plugin loading mechanism to use explicit path and function specification.

Flake lock file updates:

• Updated input 'nix':
    'github:DeterminateSystems/nix-src/c9f71f3' (2026-02-06)
  → 'github:DeterminateSystems/nix-src/fe3515c' (2026-02-27)
Flake lock file updates:

• Updated input 'nix':
    'github:DeterminateSystems/nix-src/1306149' (2026-02-20)
  → 'github:DeterminateSystems/nix-src/fe3515c' (2026-02-27)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

📝 Walkthrough

Walkthrough

This pull request refactors WebAssembly plugin invocations across multiple Nix test files by converting from positional argument syntax to explicit attribute-set (named arguments) syntax for builtins.wasm calls, affecting approximately 11 test files and one configuration file.

Changes

Cohort / File(s) Summary
Nix-WASM Plugin Test Files
nix-wasm-plugin-fib/tests/fib.nix, nix-wasm-plugin-grep/tests/grep.nix, nix-wasm-plugin-ini/tests/test1.nix, nix-wasm-plugin-mandelbrot/tests/test1.nix, nix-wasm-plugin-yaml/tests/fromYAML.nix, nix-wasm-plugin-yaml/tests/toYAML.nix, nix-wasm-plugin-yaml/tests/toYAML2.nix
Changed builtins.wasm invocations from positional argument form (e.g., <path> "function") to attribute-set form with explicit path and function fields.
Complex Plugin Test Files
nix-wasm-plugin-test/tests/call.nix, nix-wasm-plugin-test/tests/lazy.nix, nix-wasm-plugin-test/tests/pure.nix
Refactored multi-step wasm bindings into direct, inline builtins.wasm calls with named parameters; removed intermediate wasm variable bindings.
WASI Configuration
wasi/flake.nix
Removed nix-src flake input reference and updated test check to use builtins.wasm with explicit path instead of previous builtins.wasi invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • cole-h
  • lucperkins

Poem

🐰 Hop! The wasm calls now wear their names so plain,
From positional jumps to attributes refined,
No logic bends, just syntax rearranged,
Eleven files transformed with pattern unchanged—
A rabbit's refactor, organized and sane!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic. While it references updating Nix, it does not describe the actual primary changes—which involve refactoring all builtins.wasm invocations from positional argument syntax to explicit attribute-set syntax across multiple test files. Consider a more descriptive title such as 'Refactor builtins.wasm calls to use attribute-set syntax' or 'Update wasm plugin invocations to named-argument form' to better communicate the main code changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-nix

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@wasi/flake.nix`:
- Line 94: The builtins.wasm invocation at the shown call is missing the
required function attribute; update the builtins.wasm call (the invocation using
path = <plugins/nix-wasi-plugin-fib.wasm>) to include function = "fib" so the
expression becomes builtins.wasm { path = <plugins/nix-wasi-plugin-fib.wasm>;
function = "fib"; } 33, matching other usages (e.g., the fib plugin test).

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84c2273 and 0b3a5a0.

⛔ Files ignored due to path filters (2)
  • flake.lock is excluded by !**/*.lock
  • wasi/flake.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • nix-wasm-plugin-fib/tests/fib.nix
  • nix-wasm-plugin-grep/tests/grep.nix
  • nix-wasm-plugin-ini/tests/test1.nix
  • nix-wasm-plugin-mandelbrot/tests/test1.nix
  • nix-wasm-plugin-test/tests/call.nix
  • nix-wasm-plugin-test/tests/lazy.nix
  • nix-wasm-plugin-test/tests/pure.nix
  • nix-wasm-plugin-yaml/tests/fromYAML.nix
  • nix-wasm-plugin-yaml/tests/toYAML.nix
  • nix-wasm-plugin-yaml/tests/toYAML2.nix
  • wasi/flake.nix

@edolstra edolstra merged commit 17b3ab2 into main Feb 28, 2026
3 checks passed
@edolstra edolstra deleted the update-nix branch February 28, 2026 18:28
@coderabbitai coderabbitai bot mentioned this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants