Skip to content

Remove obsolete FIXME #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edolstra merged 2 commits into from
Jul 28, 2025
Merged

Remove obsolete FIXME #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9020b8a
Remove obsolete FIXME
edolstra Jul 28, 2025
8c01633
Reduce upstream diff
edolstra Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maintainers/data/release-credits-email-to-handle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,4 @@
"hey@ewen.works": "gwennlbh",
"matt@sturgeon.me.uk": "MattSturgeon",
"pbsds@hotmail.com": "pbsds"
}
}
2 changes: 1 addition & 1 deletion maintainers/data/release-credits-handle-to-name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,4 @@
"egorkonovalov": "Egor Konovalov",
"jayeshv": "jayeshv",
"vcunat": "Vladim\u00edr \u010cun\u00e1t"
}
}
2 changes: 1 addition & 1 deletion src/libexpr/primops/fetchClosure.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ static void prim_fetchClosure(EvalState & state, const PosIdx pos, Value ** args

if (attrName == "fromPath") {
NixStringContext context;
fromPath = state.coerceToStorePath(attr.pos, *attr.value, context, attrHint()); // FIXME: overflow
fromPath = state.coerceToStorePath(attr.pos, *attr.value, context, attrHint());
}

else if (attrName == "toPath") {
Expand Down
Loading