Skip to content

synthesize: support for aarch64-linux #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cole-h merged 1 commit into from
Nov 17, 2023
Merged

synthesize: support for aarch64-linux #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bootspec/src/v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ impl BootSpecV1 {
err: e,
})?;

let kernel_file = generation.join("kernel-modules/bzImage");
let kernel_image_name = match system.as_str() {
"x86_64-linux" => "bzImage",
Copy link
Member

@cole-h cole-h Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should also be i686-linux, but I imagine there are so few systems out there running that that we can revisit this later if someone notices it's broken.

Copy link
Contributor

@RaitoBezarius RaitoBezarius Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, i686-linux should use bzImage too.

_ => "Image",
};
let kernel_file = generation.join(format!("kernel-modules/{}", kernel_image_name));
let kernel =
fs::canonicalize(kernel_file.clone()).map_err(|e| SynthesizeError::Canonicalize {
path: kernel_file,
Expand Down