Merged
Conversation
Member
|
I don't think I entirely understand the value in some of these, in fact I do like that it's clearly visible that |
Contributor
Author
|
I think the idea is that if React were ever to become tree-shakable we could limit our usage to only those functions we make use of. |
Member
|
Sounds good to me. Any reason not to enable a lint for these together with this PR? Or are we still unsure about eslint-plugin-import in general, even with no-cycle turned off? |
Contributor
Author
|
I figure we can enable the import plugin in that other PR, this just got some of the changes out of the way early. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the imports changes from #9568, specifically changing to individual imports from
Reactand removing some duplicate imports.