Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: designsafe.sample.env missing DATACITE_* #1472

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Oct 9, 2024

Overview:

Gotchas during local env. setup.

PR Status:

  • Ready.

Related:

Summary of Changes:

  • add missing DATACITE_* setting

Testing Steps:

Run a local env using settings and secrets as README describes, specifically:

  • In des_django container, run ./manage.py migrate.

UI Photos:

Skipped.

DATACITE_USER=
DATACITE_PASS=
DATACITE_URL=
DATACITE_SHOULDER=
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String not required. (Why mention that?)

@wesleyboar wesleyboar marked this pull request as ready for review October 9, 2024 23:06
@rstijerina rstijerina merged commit c409732 into main Oct 9, 2024
5 checks passed
@rstijerina rstijerina deleted the wesleyboar-patch-1 branch October 9, 2024 23:11
@@ -188,3 +188,12 @@ MONGO_USER=
MONGO_PASS=
MONGO_HOST=
MONGO_DB=

##
# Miscellaneous
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am lazy right now… I permit that to stop approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants