Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/DSAPP-43: Remove data depot notifs from top-right notif bell #1459

Merged
merged 4 commits into from
Oct 16, 2024
Merged

task/DSAPP-43: Remove data depot notifs from top-right notif bell #1459

merged 4 commits into from
Oct 16, 2024
+13 −8

Conversation

rstijerina
Copy link
Member

@rstijerina rstijerina commented Oct 7, 2024 •
edited
Loading

Overview:

Removes data depot notifs from the top-right notification bell.

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Rename a file, copy a file, move a file, or delete a file.
  2. Confirm this action did not increment the unread notification bell counter, and these notifications do not show in the dropdown.
  3. Confirm job status changes still increment the counter

wesleyboar
wesleyboar reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, though WEB only appears once.

designsafe/static/scripts/ng-designsafe/providers/notifications-provider.js Outdated Show resolved Hide resolved
@rstijerina rstijerina merged commit a330250 into main Oct 16, 2024
5 checks passed
@rstijerina rstijerina deleted the task/DSAPP-43--remove-data-notifs branch October 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

@SilversunKSauri SilversunKSauri Awaiting requested review from SilversunKSauri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstijerina @wesleyboar