Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: enhance API to support frontend changes for active/inactive affected projects #701

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented Jun 6, 2024

Description

porting issue: DependencyTrack/dependency-track#3425

Addressed Issue

porting issues from 4.11 to hyades: DependencyTrack/hyades#1190

Additional Details

corresponding front end issue is already in hyades: DependencyTrack/frontend#723

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-authored-by: Adam Setch <[email protected]>
Signed-off-by: leec94 <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 86.36% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0dbf1d3) 19593 15962 81.47%
Head commit (e2641a2) 19612 (+19) 15978 (+16) 81.47% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#701) 22 19 86.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 7, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 7, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit a27e7ae into DependencyTrack:main Jun 7, 2024
9 checks passed
@leec94 leec94 deleted the port-issue-3425 branch June 7, 2024 13:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants