-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/customizable login page #986
Feat/customizable login page #986
Conversation
00c599e
to
6390bbd
Compare
@Gepardgame, the description has been tweaked so that you get credit for implementing an alternate solution to my suggestion for "Configurable Optional Banner". I see no need to implement a banner if the login dialog can convey the same information.... especially as Dependency-Track v4.12.0 release will include the ability to configure JWT expiry time (ie, how long a login session will last before it expires). |
a906220
to
7d5f7cb
Compare
@Gepardgame It looks like you modified existing commits from |
9fabc75
to
52d78ff
Compare
…e message can be configured, which will be showen on the login page Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
@nscuro Fixed it (I love patches) |
@Gepardgame, I have tested the merged PR using v4.12.0 snapshot. All looks great. The only small quibble that I have is that pressing "Update" after making a change does not result in a confirmation message to let you know that the operation was successful. |
@msymons I see. I found it how to do it, should I raise a new pull request for this? It's just 5 lines to add |
A new PR would be awesome. Thanks! |
Description
Add a option in configuration tab, to enable and set a custom welcome message:
That Welcome Message is shown on the login Screen:
Addressed Issue
Fixes #863
Closes #96
Additional Details
Checklist
- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly