Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/customizable login page #986

Merged

Conversation

Gepardgame
Copy link
Contributor

@Gepardgame Gepardgame commented Sep 6, 2024

Description

Add a option in configuration tab, to enable and set a custom welcome message:
image

That Welcome Message is shown on the login Screen:
image

Addressed Issue

Fixes #863
Closes #96

Additional Details

Checklist

@nscuro nscuro added the enhancement New feature or request label Sep 9, 2024
@msymons
Copy link
Member

msymons commented Sep 9, 2024

@Gepardgame, the description has been tweaked so that you get credit for implementing an alternate solution to my suggestion for "Configurable Optional Banner".

I see no need to implement a banner if the login dialog can convey the same information.... especially as Dependency-Track v4.12.0 release will include the ability to configure JWT expiry time (ie, how long a login session will last before it expires).

@Gepardgame Gepardgame force-pushed the feat/customizable-login-page branch 2 times, most recently from a906220 to 7d5f7cb Compare September 10, 2024 07:03
@nscuro
Copy link
Member

nscuro commented Sep 10, 2024

@Gepardgame It looks like you modified existing commits from master by accident. Could you please resolve that? It could be that you need to rebase your own commits on top of master, or raise a new PR altogether.

…e message can be configured, which will be showen on the login page

Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
@Gepardgame Gepardgame reopened this Sep 11, 2024
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
@Gepardgame
Copy link
Contributor Author

@nscuro Fixed it (I love patches)

@nscuro nscuro added this to the 4.12 milestone Sep 11, 2024
@nscuro nscuro merged commit 0d8e647 into DependencyTrack:master Sep 11, 2024
10 checks passed
@msymons
Copy link
Member

msymons commented Sep 11, 2024

@Gepardgame, I have tested the merged PR using v4.12.0 snapshot. All looks great. The only small quibble that I have is that pressing "Update" after making a change does not result in a confirmation message to let you know that the operation was successful.

@Gepardgame
Copy link
Contributor Author

@msymons I see. I found it how to do it, should I raise a new pull request for this? It's just 5 lines to add

@msymons
Copy link
Member

msymons commented Sep 11, 2024

A new PR would be awesome. Thanks!

@Gepardgame Gepardgame mentioned this pull request Sep 11, 2024
1 task
@Gepardgame
Copy link
Contributor Author

@msymons #990 Here is the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable login page Configurable Optional Banner
3 participants