Backport: Bind i18n Object To SeverityProgressBar Props #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When instantiating the SeverityProgressBar ComponentClass, the $t prop should be passed to it, so that the messages in the tooltip of the progress bar are rendered Signed-off-by: Aravind Parappil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When instantiating the
SeverityProgressBarComponentClass, the$tprop fori18nshould be passed to it, so that the messages in the tooltip of the progress bar are rendered.Screenshot of result:
Addressed Issue
Fixes #867
Backports #871
Additional Details
I (@aravindparappil46) noticed that it was working fine in
ProjectList, so referred how it was done there and replicated the same where everSeverityProgressBaris usedChecklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly