Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to projects in Portfolio Access Control view #774

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

lukas-braune
Copy link
Contributor

Description

Fix link to projects in Portfolio Access Control view

Addressed Issue

Fixes #676

Additional Details

Checklist

Copy link
Contributor

@LaVibeX LaVibeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To overcome the prettier issue, I suggest using this format.

@@ -124,7 +124,10 @@ export default {
                 }
               },
               projectUri: function (uuid) {
-                const href = router.resolve({name: 'Project', params: {uuid: uuid}}).href;
+                const href = router.resolve({
+                  name: 'Project',
+                  params: { uuid: uuid },
+                }).href;
                 const sanitizedHref = xssFilters.uriInUnQuotedAttr(href);
                 return sanitizedHref;
               },

Signed-off-by: Lukas Braune <[email protected]>
@nscuro
Copy link
Member

nscuro commented Mar 13, 2024

The joys of enforcing consistent formatting... :D

You can apply the required formatting automatically by running prettier-fix:

npm run prettier-fix

Copy link
Contributor

@LaVibeX LaVibeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that, just a simple ;

Co-authored-by: Andrés Tito <[email protected]>
Signed-off-by: Lukas Braune <[email protected]>
@nscuro nscuro added the defect Something isn't working label Mar 13, 2024
@nscuro nscuro added this to the 4.11 milestone Mar 13, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@nscuro nscuro merged commit f984f88 into DependencyTrack:master Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed links to projects under Portfolio Access Control
3 participants