Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases column is not displaying information in Vulnerabilities section #766

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

LaVibeX
Copy link
Contributor

@LaVibeX LaVibeX commented Mar 7, 2024

Description

Add Neccesary parameter to resolveVulnAliases function
common.resolveVulnALiases needs the vulnerability source and the aliases to deduplicate the list on the Aliases column,

The only parameter added to the function was "value" which do not include neither the source of the current vulnerability or their aliases.

Thats why I am adding row.source and row.aliases to the function.

I discovered that the 'return' statement was located within the condition if(typeof value !== 'undefined'), This created a problem because the function would not return anything for null values. To fix this, I moved the 'return' outside of the condition.

Addressed Issue

#765

Additional Details

Checklist

@nscuro
Copy link
Member

nscuro commented Mar 7, 2024

Thanks for the PR @LaVibeX!

Looks like there's a merge conflict here, do you mind resolving it?

@nscuro nscuro added the defect Something isn't working label Mar 7, 2024
common.resolveVulnALiases needs the vulnerability source and the aliases to deduplicate the list on the Aliases column,

In case before, the only parameter added to the function was "value" which do not include neither the source of the current
vulnerability or their aliases.

Thats why I am adding row.source and row.aliases to the function.

I discovered that the 'return' statement was located within the condition if(typeof value !== 'undefined'),
This created a problem because the function would not return anything for null values.
To fix this, I moved the 'return' outside of the condition.

Signed-off-by: Andres Tito <[email protected]>
…ource and value to the resolveVulnAliases

function and it will have same results.

No difference in taking the "return label" outside or inside the if condition, no changes required.

Run prettier.

Signed-off-by: Andres Tito <[email protected]>
@LaVibeX
Copy link
Contributor Author

LaVibeX commented Mar 14, 2024

Hi @nscuro conflict was resolved 👍

@nscuro nscuro added this to the 4.11 milestone Mar 14, 2024
@nscuro nscuro merged commit 482b143 into DependencyTrack:master Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants