-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add eslint and prettier #752
feat: add eslint and prettier #752
Conversation
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Great idea!
I am OK with doing it in this PR. N00b question: Is there a possibility to fail the build when files are not properly formatted? |
Perfect. I'll push the formatting updates to this PR in the morning.
Absolutely. I'll add a GitHub Action workflow to validate the formatting. Linting will need to come much later if/when the hundreds of errors are resolved. |
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
@nscuro @msymons - I have added a GitHub workflow, which for now i've set to continue-on-error. Some stats before running the automated linting fixes
After running prettier for code formatting
|
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
@setchy With the Codacy issue resolved, do you feel this is now ready for review? |
@nscuro - READY! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! 🙌
Description
Add eslint and prettier to help enforce consistent coding practices and formating
Addressed Issue
Additional Details
Based on feedback, I can commit the formatting changes within this PR, or a separate PR (assuming this is approved/merged).
There are 161 files with formatting updates, and 633 errors detected by eslint
Checklist