Fix redundant requests to /api/v1/component when loading project page
#726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`onlyOutdated` and `onlyDirect` were initialized with non-boolean values. Both variables have a watch on them, triggering a refresh of the components table upon change. Both variables are used as model for `c-switch` components, causing their value to transition to `false` immediately, triggering the watches and consequently table refreshes. This behavior could cause requests to be abandoned before their content was fully consumed, resulting in `EofException`s in the API server. Signed-off-by: nscuro <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes redundant requests to
/api/v1/componentwhen loading project page.Addressed Issue
Fixes #696
Additional Details
onlyOutdatedandonlyDirectwere initialized with non-boolean values. Both variables have a watch on them, triggering a refresh of the components table upon change. Both variables are used as model forc-switchcomponents, causing their value to transition tofalseimmediately, triggering the watches and consequently table refreshes.This behavior could cause requests to be abandoned before their content was fully consumed, resulting in
EofExceptions in the API server.Abandoned requests are also visible in the Network tab of the browser:
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly