Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(violations): add current fail, warn, info metrics to footer #705

Closed

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Jan 25, 2024

Description

Add footer to the existing Policy Violations card, similar to that of Portfolio Vulnerabilities that shows the current metrics for fail, warn and info policy violations.

Addressed Issue

Displays current metrics to help with usability and clarity.

Current functionality is quite fiddly to hover-over the chart and get the current policy violation metrics

Additional Details

Example using mocked data

Screenshot 2024-01-26 at 1 19 42 PM

Checklist

@setchy
Copy link
Contributor Author

setchy commented Jan 25, 2024

Happy to follow this up with separate PRs to add similar footers to the other dashboard cards (Auditing Progress, Projects, Components), if desirable

@nscuro
Copy link
Member

nscuro commented Jan 27, 2024

@setchy Thanks for this great addition! I fear merging #704 caused a merge conflict.

Happy to follow this up with separate PRs to add similar footers to the other dashboard cards (Auditing Progress, Projects, Components), if desirable.

That would indeed be much appreciated!

@nscuro nscuro added the enhancement New feature or request label Jan 27, 2024
@nscuro nscuro added this to the 4.11 milestone Jan 27, 2024
@setchy
Copy link
Contributor Author

setchy commented Jan 27, 2024

Re-raised as #707

I'll create separate PRs for the other cards

@setchy setchy closed this Jan 27, 2024
@nscuro nscuro removed this from the 4.11 milestone Jan 27, 2024
@setchy setchy deleted the feature/violations-footer branch February 21, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants