Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Show in Dependency-Graph" Button in "Affected Projects" List [improved version] #3285

Conversation

rkg-mm
Copy link
Contributor

@rkg-mm rkg-mm commented Dec 9, 2023

Description

This PR adds the Show in Dependency-Graph button to the every project in the Affected Projects tab of a vulnerability, but only if the affected project has a dependency graph.
Clicking the button redirects the user to the projects dependency graph and highlights the affected component.

Improved version, replaces #2942 :

  • The button now supports opening all affected components if vulnerability affects more than one component. The backend is adapted to return all affected components.
  • Additionally, refactored and simplified some code
  • Also improved performance for searching components in graph by factor 2-3 by removing unnecessary round trips through the graph during graph creation

Addressed Issue

DependencyTrack/frontend#533

Additional Details

Frontend PR: DependencyTrack/frontend#667

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

rbt-mm and others added 8 commits August 2, 2023 13:40
Adds the new transient attribute ´affectedComponent´ to the ´Project´
class which allows the Frontend to link from the
´Vulnerability - Affected Projects´ tab to the project's dependency
graph with the affected component being highlighted

Signed-off-by: RBickert <[email protected]>
…-graph-from-affected-projects

Add "Show in Dependency-Graph" Button in "Affected Projects" List
Adds the new transient attribute ´affectedComponent´ to the ´Project´
class which allows the Frontend to link from the
´Vulnerability - Affected Projects´ tab to the project's dependency
graph with the affected component being highlighted

Signed-off-by: RBickert <[email protected]>
* Remove unnecessary roundtrips in graph data gathering, reducing load times by factor 2-3
* make graph search support multiple component UUIDs in one call
* When loading affected projects return all affected components, so we can load the graph for all of them

Signed-off-by: Ralf King <[email protected]>
…-from-affected-projects' into master-open-dependency-graph-from-affected-projects

# Conflicts:
#	src/main/java/org/dependencytrack/persistence/VulnerabilityQueryManager.java
#	src/main/java/org/dependencytrack/resources/v1/VulnerabilityResource.java
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
@nscuro nscuro added this to the 4.11 milestone Dec 10, 2023
@nscuro nscuro merged commit 528259e into DependencyTrack:master Dec 10, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
@nscuro nscuro added the enhancement New feature or request label Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants