Fix migration of Jira config property group name - #2660
Merged
nscuro merged 1 commit intoApr 14, 2023
Conversation
Upgrades are executed before ConfigProperty defaults are populated. The current upgrade logic attempts to `UPDATE` properties that don't exist yet when the upgrade is executed. Tested on H2, Postgres 14, and MSSQL 2022 Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Apr 18, 2023
…y-track#2610, DependencyTrack/dependency-track#2660 Co-authored-by: Enora Germond <enora.germond@deveryware.com> Signed-off-by: nscuro <nscuro@protonmail.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where existing config properties are not migrated correctly from the
jirato theintegrationsnamespace.Addressed Issue
Additional Details
Upgrades are executed before
ConfigPropertydefaults are populated. The current upgrade logic attempts toUPDATEproperties that don't exist yet when the upgrade is executed.Tested on H2, Postgres 14, and MSSQL 2022
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly