-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated with title attributes and ALT tags #201
Conversation
Added title attributes to profile links, additional title attributes to other links, and ALT tag to images that had it missing.
Added title attribute tags to links. Left some out because the layout and content design does not warrant them.
Correction to a profile link
Corrections to profile links
Added title attributes.
Added title attributes and ALT tags where needed.
Should be able to close Issue #200 when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, however it seems that most of these instances of added title text are redundant or otherwise intentionally omitted. Note that for SEO purposes, search engines take into account both the link text and the title text and there is no reason to add title text if it just duplicating the link text. Additionally, I prefer to not put title text in the example code since it's not functionally required and may confuse some users. Users may choose to add it on their own if they wish.
To summarize, I am fine with adding alt text to the image on line 7 of the readme, and adding title text to the GitHub profile links, but the other instances don't seem to have much meaningful impact on the content or searchability so I think they should be reverted.
Feel free to let me know what you think.
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
This is your repository and indeed your choice moving forward. I don't fully agree with your comments regarding title tags as some search engine do use them, some categorisations stored in databases use them to find keywords, and screen readers would certainly look out for them. However, I do accept if the title tag data is duplicating the element data, there would be no point. However, I certainly was not going to start adding more content and replacing your ideal element descriptions without clearing anything with you first 😄 I have accepted your reversion changes and do appreciate the time taken to address the concerns and changes made. This should be good to merge having accepted the suggested reversions made above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making this contribution and for the extra effort. It is much appreciated 👍
Not a problem. I am glad to help the project out. Was a little concerning collecting the statics regarding the link-backs and a third of users wanting profile links do not even honour you with a link back to the repo or demo site. Very disappointing to have found those statistics |
Summary
Updated README.md:
Added title attribute tags to profile links
Added title attribute tags to other links
Added ALT image tags where required
Updated CONTRIBUTING.md:
Added title attribute tags to links
Updated CODE_OF_CONDUCT.md:
Added title attribute tags to links
Type of change
How Has This Been Tested?
Additional Information
I physically checked all profile links to make sure the example profiles were still using this feature. Positively, all profiles still use this feature but some are not linking back to the repository or demo site.
The following are using but not linking back as per the source link code provided:
https://github.com/jcs090218 - Tree Profile Image
https://github.com/yousafesaeed - CRT Monitor Image
https://github.com/HectorSaldes - White Shirt Glasses Image
https://github.com/Maagnitude - Guy Beard Grey Top Image
https://github.com/quiet-node - Smiling Guy Black Jacket Image
https://github.com/wiz64 - White Cat Image
https://github.com/thakurballary - Guy Black Beard & Hair White Top Image
https://github.com/BenjaminMichaelis - Guy Smiling Red Cap
https://github.com/PROxZIMA - Guy Black Hair & Top Glasses
https://github.com/angelofallars - Guy Red Profile Image
https://github.com/tavignesh - Never Settle with Hat Image
https://github.com/Tarun-Kamboj - Black & White Eternal Image
https://github.com/8BitJonny - Dark Face Mask Glasses Image
This is a result of 13/41 meaning on average, 32% or 1/3rd of users do not actively provide a link back to the repository. Seems a shame to use a feature and not really give credit to the developer.