Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consistent use of quotes, simplified tests #170

Merged
merged 3 commits into from
Nov 27, 2022
Merged

fix: Consistent use of quotes, simplified tests #170

merged 3 commits into from
Nov 27, 2022

Conversation

DenverCoder1
Copy link
Owner

Summary

Use single quotes for SVG attributes for consistency.

Simplified tests to not use files for everything - easier to maintain in the future.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

@DenverCoder1 DenverCoder1 added the refactoring Restructured code in a way it does not affect functionality label Nov 27, 2022
@DenverCoder1 DenverCoder1 merged commit 69911e7 into main Nov 27, 2022
@DenverCoder1 DenverCoder1 deleted the simplified-tests branch November 27, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Restructured code in a way it does not affect functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DenverCoder1