Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean Translation #271

Closed
wants to merge 1 commit into from
Closed

Add Korean Translation #271

wants to merge 1 commit into from

Conversation

evan-hwang
Copy link
Contributor

@evan-hwang evan-hwang commented Jul 5, 2022

Description

I'm adding a translation for a Korean developer.
I am also a Korean developer.
I translated it because Korean developers love the project so much. Thank you. 🙏

I interpreted the word "Streak" as "work that I've been doing."
So I translated 'Current Streak' into 'Current Continuous Commit Count' and 'Longest Streak' into 'Maximum Continuous Commit Count'.

Fixes #236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

스크린샷 2022-07-05 오후 10 57 42

I'm adding a translation for a Korean developer.

I interpreted the word "Streak" as "work that I've been doing." 
So I translated 'Current Streak' into 'Current Continuous Commit Count' and 'Longest Streak' into 'Maximum Continuous Commit Count'.
@evan-hwang evan-hwang changed the title Update translations.php Add Korean Translation Jul 5, 2022
@evan-hwang evan-hwang closed this Jul 5, 2022
@evan-hwang evan-hwang deleted the patch-1 branch July 5, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗪 Add Translations to Streak Stats
1 participant