Worldguard properties update #441
Conversation
…orldguard_bridge_update
|
Most of those renames seem a bit unnecessary. The |
|
fixed |
|
|
||
| public class WorldGuardPlayerExtensions { | ||
|
|
||
| public static Warning worldguardCanBuild = new SlowWarning("worldguardCanBuild", "The tag 'PlayerTag.worldguard.can_build' from Depenizen/Worldguard is deprecated: use 'PlayerTag.worldguard_can_build'"); |
There was a problem hiding this comment.
Should use the Deprecations.pointlessSubTagPrefix
There was a problem hiding this comment.
uh do I need to register it in denizen-core? pointlessSubTagPrefix is private
| }; | ||
|
|
||
| PlayerTag.tagProcessor.registerTag(ObjectTag.class, "worldguard", runnable); | ||
| PlayerTag.tagProcessor.registerTag(ObjectTag.class, "wg", runnable); |
There was a problem hiding this comment.
This wg part can be dropped - there were scraps of code about it but it wasn't functionally implemented (not listed in handledTags)
| // @returns ObjectTag | ||
| // @plugin Depenizen, WorldGuard | ||
| // @description | ||
| // Returns the boolean state of a flag for that player at the specified location. |
There was a problem hiding this comment.
Meta should specify what the default location if unspecified is
|
fixed |
Changes:
PlayerTag.worldguard.can_build[<location>]/PlayerTag.wg.can_build[<location>]->PlayerTag.worldguard_can_build[<location>]PlayerTag.worldguard.test_flag[<name>]/PlayerTag.wg.test_flag[<name>]->PlayerTag.worldguard_flag[flag=<name>(;location=<at>)]Note
PlayerTag.worldguard_flagnow defaults location to the player's location when there's no input provided and also when there's an invalid location provided. Is this fine? Or should the tag fail when invalid location is provided?