Hotfix/make token more unique #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
from
9c8065a
to
9a91118
Compare
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
from
9a91118
to
bb33b81
Compare
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
2 times, most recently
from
b6ff9ee
to
e17b2de
Compare
symroe
reviewed
Jul 5, 2023
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
10 times, most recently
from
f99f42d
to
34a0649
Compare
symroe
reviewed
Jul 19, 2023
requirements/base.txt
Outdated
| @@ -16,6 +16,7 @@ redis==4.6.0 | |||
| Pillow==9.5.0 | |||
| icalendar==5.0.7 | |||
| dealer==2.1.0 | |||
| setuptools==58.2.0 | |||
There was a problem hiding this comment.
It looks like this is an error with pyYAML. We're using 5.4.1 and the latest is 6.0.1. I took a look at the changelog and the version after the one we're on seems to fix this.
So I think the solution here is to upgrade pyYAML rather than pin setuptools to an older version.
symroe
force-pushed
the
hotfix/make-token-more-unique
branch
4 times, most recently
from
6b0a2cc
to
ac5a6a8
Compare
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
2 times, most recently
from
1ca3fa7
to
7bb71f3
Compare
VirginiaDooley
force-pushed
the
hotfix/make-token-more-unique
branch
from
7bb71f3
to
935ae94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored @symroe
Ref https://democracy-club-gp.sentry.io/issues/4152565476/?project=1426221&query=feedback&referrer=issue-stream&statsPeriod=14d&stream_index=0
Previous to this change, tokens were being set to
Noneas a default which caused aMultiple objects returnederror. Here, we've set the token in the model and tested for uniqueness.In the course of this work, I ran into a deprecation issue with
setuptoolswhich is a dependency.