feat(lint): add changie validation job to lint action #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #82 Add changie validation job to lint action. * Add a new job `changie-validation` to `.github/workflows/lint.yml` to check for changie entries in `.changes/unreleased` directory. * Skip the `changie-validation` job if the `.changes` directory does not exist. * Skip the `changie-validation` job if the labels `no-changie-required` or `dependencies` are set. * Replace deprecated `set-output` command with `echo "{name}={value}" >> $GITHUB_OUTPUT` in the `changie-validation` job. * Add a comment using the gh cli if a changie entry is required, ensuring only a single comment is made and updated if it was closed. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DelineaXPM/github-workflows/issues/82?shareId=XXXX-XXXX-XXXX-XXXX).
sheldonhull
changed the title
sheldonhull
changed the title
* Set GH_TOKEN environment variable to ${{ github.token }} for the changie-validation job to enable gh pr comment command
|
Add GH_TOKEN environment variable to changie-validation job
|
* Add `changie-validation` job to check for changie entries in `.changes/unreleased` directory
* Skip `changie-validation` job if `.changes` directory does not exist or if labels `no-changie-required` or `dependencies` are set
* Replace deprecated `set-output` command with `echo "{name}={value}" >> $GITHUB_OUTPUT`
* Add comment using gh cli if changie entry is required, ensuring only a single comment is made
* Map `GH_TOKEN` in `env` for `check_labels` and `validate_changie_entry` steps
|
Add
|
|
Update
|
* **Fix environment variable mapping:** - Remove `with` block and move `env` block directly under `run` for `check_labels` and `validate_changie_entry` steps - Ensure `GH_TOKEN` is correctly mapped in `env` for both steps
* Add checkout step to changie-validation job to ensure the repository is checked out before running validation steps
|
Add checkout step to changie-validation job in lint workflow
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
✅ changie entry was found |
1 similar comment
|
✅ changie entry was found |
|
tweak to echo and add more context detail |
|
make it work |
|
remove readme changes |
auto-merge was automatically disabled
August 13, 2024 02:56
Pull request was closed
sheldonhull
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Add changie validation job to lint action.
changie-validationto.github/workflows/lint.ymlto check for changie entries in.changes/unreleaseddirectory.changie-validationjob if the.changesdirectory does not exist.changie-validationjob if the labelsno-changie-requiredordependenciesare set.set-outputcommand withecho "{name}={value}" >> $GITHUB_OUTPUTin thechangie-validationjob.For more details, open the Copilot Workspace session.